- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 496
Fix chat message length calculation with colorCoded enabled #4370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    When colorCoded = true, the chat message length calculation was incorrectly counting hex color codes as part of the text. This caused the message width to be miscalculated, so some texts did not fit properly in the chat box. This PR updates the logic to ignore hex color codes during length calculation, ensuring that only visible characters are counted. Result Chat messages now display correctly without being cut off. Length is calculated only from visible text, not formatting codes.
comments deleted.
              
                    MegadreamsBE
  
              
              suggested changes
              
                  
                    Aug 18, 2025 
                  
              
              
            
            
              
                    MegadreamsBE
  
              
              approved these changes
              
                  
                    Aug 18, 2025 
                  
              
              
            
            
              
                    tederis
  
              
              requested changes
              
                  
                    Aug 19, 2025 
                  
              
              
            
            
              
                    FileEX
  
              
              approved these changes
              
                  
                    Aug 19, 2025 
                  
              
              
            
            
              
                    tederis
  
              
              approved these changes
              
                  
                    Aug 20, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
When colorCoded = true, the chat message length calculation was incorrectly counting hex color codes as part of the text. This caused the message width to be miscalculated, so some texts did not fit properly in the chat box.
This PR updates the logic to ignore hex color codes during length calculation, ensuring that only visible characters are counted.
Result
Chat messages now display correctly without being cut off.
Length is calculated only from visible text, not formatting codes.